SceneSwitcher icon indicating copy to clipboard operation
SceneSwitcher copied to clipboard

bug: macro creation is difficult to use with a screen reader

Open marrie opened this issue 2 years ago • 4 comments

Describe the bug When using nvda and trying to navigate the macros dialogue, buttons are not clearly labeled as to what they should do, sections don't appear to be properly denoted, and check boxes are not properly labeled.

To Reproduce Steps to reproduce the behavior: after downloading and installing nvda:

  1. launch obs
  2. go to tools
  3. down arrow until you hear "advanced scene switcher" and hit enter.
  4. navigate to the macros tab with right arrow.

Now start to tab through the interface. I can try and show a video clip except I can't record obs I don't think without having another copy open. If you need a demo as well let me know and I can see what I can do.

Expected behavior

I expect all controls to be read, elements to be labeled and tab order to make sense. Note that tab order can be different from what the sighted person sees as long as it makes sense. Logs Please provide a log of your issue with verbose logging enabled (See General tab of the plugin).
In case of a crash, please also include the corresponding crash log.
See here for a description of where to find the log files and how to share them.
Please share the currently used plugin settings by exporting them to a file (See General tab of the plugin).
If applicable, add screenshots to help explain your problem. obs log advanced scene switcher settings

Version information

  • OS: [e.g. Windows 10] Windows 11 22H2 (AMD64) build 22621.2715
  • OBS Version [e.g. 27.1.3] 29.x
  • Plugin Version [e.g. 1.17.1] 1.24.0

Additional context If you need any demos of how I use nvda I can try and provide them upon request. I realize this might be the first comment you got regarding accessibility however as a streamer / content creator I should be able to do everything with this plugin with ease. Right now, I am pulling my hair out. Thanks so much and look forward to many more uses of this plugin.

marrie avatar Dec 03 '23 20:12 marrie

Thank you for pointing this out! I will add it to the todo list.

So far I have not looked into the tab order at all and this might be quite a bit of work since widgets are added and removed dynamically in the action / condition areas, which probably affects the tab order a lot. So let me apologize in advance if this will take a while.

Regarding "I expect all controls to be read": Do you know how I can achieve this for e.g. buttons which do not have any text or in general how I can control what is read out and what is not? Are you aware of how this was solved for OBS itself?

WarmUpTill avatar Dec 04 '23 19:12 WarmUpTill

in fact I did bug the nonlabelled buttons on obs's GitHub, as I'm facing the same issue in some of those controls. They are aware of the issue, I'm just not sure how to solve that.

Because the order of the macro actions we can place, and regarding the fact they could change, maybe if the check boxes were labeled properly and / or if sections were somehow divided so we could easily jump to them? I'm not sure if we can reorder sections yet, but one step at a time for now. I look forward to problem solving this with you. Maybe I'm also overthinking this as well.

Thanks so much.

marrie avatar Dec 04 '23 20:12 marrie

I merged some initial changes adjusting the tab order and adding more tool tips which seem to be picked up by the screen readers. The bluk of the work - the support for the macro conditions and actions - is still pending however.

WarmUpTill avatar Jan 30 '24 18:01 WarmUpTill

Thanks so much. I’m not home for the next 2 weeks so cannot test. If you need to download nvda while I’m away you can get nvda at their website http://nvda-project.org/ , if I forgot not link it in my original bug report. Of corset her is no substitute for testing with an experienced screen reader user, however this will work for the time being and will enable you to see what I’m seeing, no pun intended.

Thanks so much for working with this. It is very much appreciated.

marrie avatar Jan 30 '24 20:01 marrie