Brian Ward

Results 396 comments of Brian Ward

Storing it alongside balls/strikes/pitch speed also allows easier control over where the user would like it to be. For example, I think I'd want it as a separate text element...

How do you feel about this setting being in the layout rather than the config?

I wouldn’t want it on the pitcher text I think, I would want it like the speeds (probably under them, on my layout), but it could be an “off” “pitcher...

I don’t think so, you should be able to append it right before rendering. I can sketch this out in my own fork if it’s helpful, you already did the...

That sounds good to me

Can you post the config.json you are using?

Are there any objections to committing @rok-cesnovar's grammar suggestions and then merging this? I've had a few people recently ask me about getting started docs here

No worries Steve! I wasn't asking to try to rush you, but more ask if you wanted someone else (e.g. me) to go through Rok's suggestions and then merge this

I just went through all of @rok-cesnovar's grammar and spelling line edits, so assuming he is okay with the content of this I believe we should merge after CI

That’s no worse that the behavior before this PR, right?