Brian Ward comments

Results 733 comments of


                                            Brian Ward

Laplace: Add mean argument to helper distributions

@SteveBronder similar to the last PR, the tests for math are passing, the failure is just because the compiler update needs to be merged simultaneously. So this is ready to...

Laplace: Add mean argument to helper distributions

@SteveBronder https://github.com/stan-dev/stanc3/pull/1523 still needs to be reviewed as well so they can be merged together

Simplify some common patterns in Cpp DSL

@SteveBronder I agree with your major comments. I've removed the indexing shorthand and swiched to `{}` for construction and I agree it reads better than before.

0035 pre model gqs

Rendered: https://github.com/stan-dev/design-docs/blob/0035-pre-model-gqs/designs/0035-pre-model-gqs.md

#3127 Add log sum exp func

> The intention of the function is to add two containers a and b using the log-sum-exp thing and returning again a container, right? Correct, that is what @spinkney requested...

#3127 Add log sum exp func

I think the only requirement should be that the containers passed must be the same size, but if one is a row vector and the other is a column vector...

#3127 Add log sum exp func

I think the most useful thing would probably be to work over arbitrary containers of the same size. I think the apply_scalar_binary helpers may automate that

#3127 Add log sum exp func

I may be misunderstanding, but I think if both arguments are matricies I think it is correct to require them to be the same size. We don’t generally do any...

#3127 Add log sum exp func

I believe check_matching_dims does what we’d want it to do for that purpose

#3127 Add log sum exp func

@andrjohns the existing function returns a scalar, the feature request was for something that worked element wise and returned a container