Warcraft-Guardians-of-Azeroth icon indicating copy to clipboard operation
Warcraft-Guardians-of-Azeroth copied to clipboard

Brewmaster

Open sejtalk opened this issue 3 years ago • 10 comments

Changelog:

  • Added Brewmaster lifestyle trait.
  • Added 5 different brews and ability to create them for nrew masters.
  • Added targetted decision that allows to drink alcohol.

How to test:

Pick Carousing focus and use decision to become Brewmaster. Create all 5 types of brews and test them on yourself and other char. Try to use up the brew keg completely.

sejtalk avatar Jul 12 '20 16:07 sejtalk

Don't use X/3 in artifact name. It will be shown in event localization that uses artifact names. Create a custom localization that will show amount of uses in description instead.

I thought about it some more time and come to conclusion that using words in name might be a better idea. Like "Full Barrel of X" -> "Half Full Barrel of X" ->"Half Empty Barrel of X", etc.

MemeWizard avatar Aug 29 '20 07:08 MemeWizard

Don't use X/3 in artifact name. It will be shown in event localization that uses artifact names. Create a custom localization that will show amount of uses in description instead.

I thought about it some more time and come to conclusion that using words in name might be a better idea. Like "Full Barrel of X" -> "Half Full Barrel of X" ->"Half Empty Barrel of X", etc.

Done

sejtalk avatar Aug 29 '20 11:08 sejtalk

One bug, when I had an almost empty kegs of sulfuron slammer, tiger stout, serpent ale, and metal brew, I drank the sulfuron slammer and it was removed from my artifacts, but I got serpent ale modifier. I later drank the metal brew and the same thing happened.

Everything else worked fine.

Could you try doing it again? I fixed the bug where the artifact was destroyed before it checked what type it is to add correct modifier and i suspect it was the reason.

sejtalk avatar Aug 29 '20 17:08 sejtalk

The brewmaster AI does make brews but I haven't seen the AI drink it themselves or give it to others.

Otherwise looks fine.

Ai should use decisions more often now. Keep in mind it will only pour a drink for themselves and their friends and family.

sejtalk avatar Aug 31 '20 17:08 sejtalk

Ai should use decisions more often now. Keep in mind it will only pour a drink for themselves and their friends and family.

It doesn't work for me, for some reason.

There is a friend of mine that has a brewmaster trait and money but doesn't want to brew anything at all.

AI money trait No brew AI money trait No brew

There is a friend of mine that brews a lot (9 full kegs) but doesn't drink himself and doesn't pour drinks to others (family/friends).

AI brews a lot but doesn't drink AI brews a lot but doesn't drink

Unlanded and baron tier chars dont use this decision for performance reasons. I will look into ai not drinking and pouring.

sejtalk avatar Oct 02 '20 11:10 sejtalk

There's one not really good design moment with the keg fullness. You can drink it to the bottom, give the keg to another character and they will be happy like you gifted the full keg. I would recommend making the keg one time consumable.

we can just make it so you cant gift it

sejtalk avatar Dec 25 '20 18:12 sejtalk

we can just make it so you cant gift it

Limiting players without clear reason doesn't sound good.

zumbak04 avatar Dec 25 '20 18:12 zumbak04

we can just make it so you cant gift it

Limiting players without clear reason doesn't sound good.

actually we can block gifting kegs that are not full since you wouldnt gift opened alcohol bottle

sejtalk avatar Dec 25 '20 18:12 sejtalk

actually we can block gifting kegs that are not full since you wouldnt gift opened alcohol bottle

This sounds better.

zumbak04 avatar Dec 25 '20 18:12 zumbak04

actually we can block gifting kegs that are not full since you wouldnt gift opened alcohol bottle

This sounds better.

implemented

sejtalk avatar Dec 25 '20 18:12 sejtalk