DisCo icon indicating copy to clipboard operation
DisCo copied to clipboard

[BUG] a bug in the dataset/tiktok_video_dataset.py

Open ljh0v0 opened this issue 1 year ago • 0 comments

When sampling a segment of video to train the temporal module, the length of the dataset is divided by the train_sample_interval = 4.

But in this line: https://github.com/Wangt-CN/DisCo/blob/8538889c9ee9edd8dd43ffee182d1a91ce7a9828/dataset/tiktok_video_dataset.py#L295

the code limits the start frame id to be min(idx, len(self) - 1). The len(self) = num_frames / train_sample_interval, so it means only the first quarter of the images in the dataset can be the first frame. Any video segment whose first frame id is larger than num_frames / train_sample_interval will be replaced by the segment starting with the id num_frames / train_sample_interval-1. This causes only the first quarter of datasets will be used in the training.

ljh0v0 avatar Jan 30 '24 23:01 ljh0v0