WalletWasabi icon indicating copy to clipboard operation
WalletWasabi copied to clipboard

Introduce MinInputCountByBlameRound

Open turbolay opened this issue 2 years ago • 2 comments

Description of the idea: #12443

(I know the multiplier should probably be getting ridden off, but considering that it's how we do for MinInputCountByRound I think it should work in the same way)

@lontivero would you prefer another solution? I could instead:

  • add a bool isBlame in RoundParameters.Create
  • enforce the different minimum in RoundBlameRoundFactory.CreateBlameRoundParameter.
  • Remove MinInputCountByBlameRound and instead have a multiplier that is applied to round.Parameters.MinInputCount of a fresh round.

If this PR is implemented, it should come along with a change in coordinator's config, MinInputCountByRoundMultiplier from 0.4 to 0.5

turbolay avatar Feb 13 '24 07:02 turbolay

cACK

lontivero avatar Feb 13 '24 16:02 lontivero

The config contains the values needed for creating rounds, this means that the config instance is required by the rounds' creation code.

When a blame round is created it can use values from the previous round (blame or not) and from config. In summary, config can always be used to create a round.

My previous comment was:

Never use Config anywhere else except in the round creation.

lontivero avatar Feb 20 '24 23:02 lontivero

Closed by https://github.com/zkSNACKs/WalletWasabi/pull/12524#pullrequestreview-1903288598

molnard avatar Feb 28 '24 12:02 molnard