WalletWasabi icon indicating copy to clipboard operation
WalletWasabi copied to clipboard

[UI] Broken history layout when scrolling down.

Open yahiheb opened this issue 1 year ago • 9 comments

The rows are not correctly aligned.

SC1

How to reproduce:

  • Start Wasabi
  • Make the size as small as possible
  • Load a wallet
  • Click on any other wallet
  • Go back to the first wallet
  • On the history list scroll to the far right.
  • Use the down arrow to scroll down by clicking a couple of times.

yahiheb avatar Feb 06 '24 18:02 yahiheb

Idk if it is the same or similar to #12372

yahiheb avatar Feb 06 '24 18:02 yahiheb

Could repro image

wieslawsoltes avatar Feb 07 '24 16:02 wieslawsoltes

Seems like cells in row got shifted to the right by layout image

wieslawsoltes avatar Feb 07 '24 16:02 wieslawsoltes

This happens even for larger window sizes image

wieslawsoltes avatar Feb 07 '24 16:02 wieslawsoltes

https://github.com/zkSNACKs/WalletWasabi/assets/2297442/35ebf4e7-f475-4b5e-9930-5540360f8bbc

wieslawsoltes avatar Feb 07 '24 16:02 wieslawsoltes

Seems like scrolling is not invalidating layout, it only fixes when you scroll to end of left viewport.

https://github.com/zkSNACKs/WalletWasabi/assets/2297442/09ba65cc-f346-48d8-877b-2993c17b7141

wieslawsoltes avatar Feb 07 '24 16:02 wieslawsoltes

Could repro in original sample image

wieslawsoltes avatar Feb 07 '24 17:02 wieslawsoltes

Could repro in original sample image


       public CountriesPageViewModel()
        {
            _data = new ObservableCollection<Country>(Countries.All);

            Source = new FlatTreeDataGridSource<Country>(_data)
            {
                Columns =
                {
                    new TextColumn<Country, string>("Country", x => x.Name, (r, v) => r.Name = v, new GridLength(1, GridUnitType.Star), new()
                    {
                        IsTextSearchEnabled = true,
                    }),
                    new TemplateColumn<Country>("Region", "RegionCell", "RegionEditCell"),
                    new TextColumn<Country, int>("Population", x => x.Population, new GridLength(200, GridUnitType.Auto), new TextColumnOptions<Country>() { MinWidth = new GridLength(300)}),
                    new TextColumn<Country, int>("Area", x => x.Area, new GridLength(200, GridUnitType.Auto), new TextColumnOptions<Country>() { MinWidth = new GridLength(200)}),
                    new TextColumn<Country, int>("GDP", x => x.GDP, new GridLength(200, GridUnitType.Auto), new()
                    {
                        TextAlignment = Avalonia.Media.TextAlignment.Right,
                        MaxWidth = new GridLength(150)
                    }),
                }
            };
            Source.RowSelection!.SingleSelect = false;
        }

wieslawsoltes avatar Feb 07 '24 17:02 wieslawsoltes

Reported https://github.com/AvaloniaUI/Avalonia.Controls.TreeDataGrid/issues/256

wieslawsoltes avatar Feb 07 '24 17:02 wieslawsoltes