web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

Chore: missing "unsupportedChain"

Open venturars opened this issue 6 months ago • 2 comments

Description

‘UnsupportedChain’ is now accepted as a View type.

Type of change

  • [x] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3064 For GH issues: closes #4507

Checklist

  • [x] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [x] My changes generate no new warnings
  • [x] I have reviewed my own code
  • [x] I have filled out all required sections
  • [ ] I have tested my changes on the preview link
  • [ ] Approver of this PR confirms that the changes are tested on the preview link

venturars avatar Jun 16 '25 09:06 venturars

⚠️ No Changeset found

Latest commit: 01f97b9ec73fa78f16dac9deaaceb0727be6b124

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 16 '25 09:06 changeset-bot[bot]

@venturars is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 16 '25 09:06 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-gallery ✅ Ready (Inspect) Visit Preview Jul 23, 2025 6:25am

vercel[bot] avatar Jul 16 '25 23:07 vercel[bot]

Hi @venturars ! Wondering why you need this view in the open views supported list? This view is not intended to be open programatically as it automatically responds to unsupported networks as per your config.

tomiir avatar Jul 17 '25 13:07 tomiir

@tomiir hello friend, I know it's not a common case, but sometimes a developer might need this view when fixing something. You can see an example here: https://github.com/reown-com/appkit/issues/4511.

Anyway, this is an open request for discussion—when I opened this PR, my intention was to help improve code consistency. But if you think including the "UnsupportedChain" view isn’t the best option, I’m totally fine with that too

venturars avatar Jul 17 '25 22:07 venturars

@venturars thanks for the contribution! I'm closing this as this one is old and not needed at this moment, and considering adding functionality requires to be followed up with unit and integration tests - this means the PR requires more.

We appreciate it and would love to hear back if there is specific issue that AppKit could improve, and we could discuss & shipt it. Best

enesozturk avatar Sep 18 '25 11:09 enesozturk