web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

Fix: export types to enable proper type inference from useAppKit function

Open venturars opened this issue 6 months ago • 3 comments

Description

Export types AppKitBaseClient, OpenOptions, and Views to enable proper type inference when using useAppKit function.

https://imgur.com/a/s3b94Fy

Type of change

  • [ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3050 For GH issues: closes #4496

Checklist

  • [x] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [x] My changes generate no new warnings
  • [x] I have reviewed my own code
  • [x] I have filled out all required sections
  • [x] I have tested my changes on the preview link
  • [ ] Approver of this PR confirms that the changes are tested on the preview link

venturars avatar Jun 11 '25 09:06 venturars

⚠️ No Changeset found

Latest commit: fcc1570cbff804d6c6cba57cc471c3c88a04daf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 11 '25 09:06 changeset-bot[bot]

@venturars is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 11 '25 09:06 vercel[bot]

@enesozturk, I’ve committed the recommended changes

venturars avatar Jun 15 '25 19:06 venturars

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 3:21pm
appkit-gallery ✅ Ready (Inspect) Visit Preview Jul 17, 2025 3:21pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview Jul 17, 2025 3:21pm

vercel[bot] avatar Jul 16 '25 22:07 vercel[bot]

@venturars Looks good! Can you push changeset file so you'd be credited in the next release? 🙏🏽 To do so:

pnpm changeset (in the root)
  1. Select all packages
  2. Skip major
  3. Skip minor
  4. Give description: "Exports type definitions of Base class for better TS support when using hooks"

enesozturk avatar Jul 17 '25 13:07 enesozturk

@enesozturk hey friend, did you already push the changeset file, right?

venturars avatar Jul 17 '25 22:07 venturars