Remove wallet guide component and related functionality (APKT-2883)
Remove wallet guide component and related functionality (APKT-2883)
Summary
This PR completely removes the "Haven't got a wallet?" button component (w3m-wallet-guide) and all related functionality from the AppKit codebase as specified in Linear ticket APKT-2883.
Changes Made
Component Removal
- ✅ Deleted
packages/scaffold-ui/src/partials/w3m-wallet-guide/index.ts - ✅ Deleted
packages/scaffold-ui/src/partials/w3m-wallet-guide/styles.ts
Connect View Updates
- ✅ Removed
guideTemplatemethod fromw3m-connect-view - ✅ Removed
walletGuideproperty and related state - ✅ Removed wallet guide conditional rendering logic
- ✅ Cleaned up imports and unused code
Router Updates
- ✅ Removed 'Create' route that rendered with
walletGuide="explore"
Configuration Removal
- ✅ Removed
enableWalletGuideproperty fromOptionsController - ✅ Removed
setEnableWalletGuidemethod - ✅ Removed
enableWalletGuideinitialization fromappkit-base-client
Type Definitions
- ✅ Removed
WalletGuideTypefrom TypeUtil files in:packages/controllers/src/utils/TypeUtil.tspackages/ui/src/utils/TypeUtil.tspackages/ui-new/src/utils/TypeUtil.ts
Test Updates
- ✅ Removed wallet guide test cases from
w3m-connect-view.test.ts - ✅ Removed wallet guide methods from laboratory test files
- ✅ Updated test mocks to remove wallet guide references
Social Login Widget
- ✅ Removed wallet guide properties and logic
- ✅ Simplified template methods to return null
- ✅ Cleaned up unused imports and constants
Documentation
- ✅ Added breaking change entry to
CHANGELOG.mdwith migration guide
Issues Fixed
This removal addresses the following UI bugs:
- The top section was empty when email/social was disabled and users clicked "Haven't got a wallet?"
- The "or" separator was displayed twice when email/social was enabled and users clicked the button
- Conflicts with the "UX by Reown" component
Breaking Changes
⚠️ BREAKING CHANGE: The enableWalletGuide configuration option has been completely removed.
Migration Guide
If you were using the enableWalletGuide option in your AppKit configuration, you can safely remove it:
// Before
createAppKit({
// ... other options
enableWalletGuide: false // Remove this line
})
// After
createAppKit({
// ... other options
// enableWalletGuide option no longer exists
})
Testing
- ✅
pnpm buildpasses successfully - ✅
pnpm run prettier:formatpasses successfully - ✅ All TypeScript compilation errors resolved
- ✅ Removed wallet guide test cases updated appropriately
Linear Ticket
Fixes: APKT-2883
Link to Devin run
https://app.devin.ai/sessions/4724080d5beb4e629c88cde28f19655a
Requested by
🤖 Devin AI Engineer
I'll be helping with this pull request! Here's what you should know:
✅ I will automatically:
- Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
- Look at CI failures and help fix them
Note: I can only respond to comments from users who have write access to this repository.
⚙️ Control Options:
- [ ] Disable automatic comment and CI monitoring
🦋 Changeset detected
Latest commit: 554ac2703aa94caf66f1ac32a0a460b5970950d4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
| Name | Type |
|---|---|
| @reown/appkit | Major |
| @reown/appkit-adapter-bitcoin | Patch |
| @reown/appkit-adapter-ethers | Patch |
| @reown/appkit-adapter-ethers5 | Patch |
| @reown/appkit-adapter-solana | Patch |
| @reown/appkit-adapter-wagmi | Patch |
| @reown/appkit-cdn | Patch |
| @reown/appkit-experimental | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| appkit-basic-html | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 10, 2025 11:09am |
| appkit-demo | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 10, 2025 11:09am |
| appkit-laboratory | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 10, 2025 11:09am |
10 Skipped Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| appkit-basic-example | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| appkit-basic-sign-client-example | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| appkit-basic-up-example | ⬜️ Ignored (Inspect) | Visit Preview | Jun 10, 2025 11:09am | |
| appkit-ethers5-bera | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| appkit-nansen-demo | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| appkit-vue-solana | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| appkit-wagmi-cdn-example | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| ethereum-provider-wagmi-example | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| next-wagmi-solana-bitcoin-example | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am | ||
| vue-wagmi-example | ⬜️ Ignored (Inspect) | Jun 10, 2025 11:09am |
| Warnings | |
|---|---|
| :warning: |
🔑 Potential High‑entropy string detected in apps/laboratory/tests/shared/validators/ModalValidator.ts (line 290): |
Generated by :no_entry_sign: dangerJS against 554ac2703aa94caf66f1ac32a0a460b5970950d4
Coverage Report
| Status | Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔵 | Lines | 76.85% | 28704 / 37350 |
| 🔵 | Statements | 76.85% | 28704 / 37350 |
| 🔵 | Functions | 67.95% | 2407 / 3542 |
| 🔵 | Branches | 84.22% | 5859 / 6956 |
File Coverage
This needs a changeset
Unit tests are failing. Also, rebuild the changeset