WalletConnect
Replace qrcode dependency with @paulmillr/qr
Replace qrcode dependency with @paulmillr/qr
This PR replaces the dependency on qrcode with qr in the QR code implementation. Note that the qr package on npm is what used to be @paulmillr/qr, which is now deprecated.
The changes include:
- Replacing the
qrcodedependency withqrin package.json - Updating the
getMatrixfunction to useencodeQRfromqrlibrary - Maintaining the custom rendering logic for QR codes
- Ensuring all tests pass
Fixes: https://github.com/WalletConnect/walletconnect-monorepo/issues/6018
Link to Devin run: https://app.devin.ai/sessions/4d1b38e321f84273abdd8cfc5ea42550 Requested by: Ben Kremer ([email protected])
![devin-ai-integration[bot] avatar](https://avatars.githubusercontent.com/in/811515?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚠️ No Changeset found
Latest commit: 68a9fb3fcf611b51c5f6ee257f8c19f1299ab066
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| appkit-demo | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 22, 2025 2:42pm |
| appkit-laboratory | ✅ Ready (Inspect) | Visit Preview | May 22, 2025 2:42pm |
11 Skipped Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| appkit-basic-ep | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| appkit-basic-example | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| appkit-basic-sign-client-example | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| appkit-basic-up-example | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| appkit-ethers5-bera | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| appkit-nansen-demo | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| appkit-vue-solana | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| appkit-wagmi-cdn-example | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| ethereum-provider-wagmi-example | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| next-wagmi-solana-bitcoin-example | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm | ||
| vue-wagmi-example | ⬜️ Ignored (Inspect) | May 22, 2025 2:42pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
🤖 Devin AI Engineer
I'll be helping with this pull request! Here's what you should know:
✅ I will automatically:
- Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
- Look at CI failures and help fix them
Note: I can only respond to comments from users who have write access to this repository.
⚙️ Control Options:
- [ ] Disable automatic comment and CI monitoring
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| appkit-demo | ❌ Failed (Inspect) | May 22, 2025 1:02pm | ||
| appkit-laboratory | ❌ Failed (Inspect) | May 22, 2025 1:02pm |
11 Skipped Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| appkit-basic-ep | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| appkit-basic-example | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| appkit-basic-sign-client-example | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| appkit-basic-up-example | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| appkit-ethers5-bera | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| appkit-nansen-demo | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| appkit-vue-solana | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| appkit-wagmi-cdn-example | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| ethereum-provider-wagmi-example | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| next-wagmi-solana-bitcoin-example | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm | ||
| vue-wagmi-example | ⬜️ Ignored (Inspect) | May 22, 2025 1:02pm |
| Warnings | |
|---|---|
| :warning: | File packages/ui-new/package.json contains a KEY or SECRET |
| :warning: | File packages/ui/package.json contains a KEY or SECRET |
Generated by :no_entry_sign: dangerJS against 20e6fdee7cfe56de8c3dad7783aac30900e739a4
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coverage Report
| Status | Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔵 | Lines | 76.26% | 26876 / 35242 |
| 🔵 | Statements | 76.26% | 26876 / 35242 |
| 🔵 | Functions | 67.94% | 2268 / 3338 |
| 🔵 | Branches | 83.77% | 5377 / 6418 |
File Coverage
| File | Stmts | Branches | Functions | Lines | Uncovered Lines |
|---|---|---|---|---|---|
| Changed Files | |||||
| packages/ui/src/utils/QrCode.ts | 100% | 97.8% | 100% | 100% | |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
| Diff | Package | Supply Chain Security |
Vulnerability | Quality | Maintenance | License |
|---|
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}
