web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

feat(controllers): add edge case tests for ChainController's network switching (APKT-2902)

Open devin-ai-integration[bot] opened this issue 7 months ago • 8 comments

Edge case tests for ChainController's network switching

Description

This PR adds comprehensive tests for edge cases in the ChainController's network switching functionality:

  1. Handling of unsupported networks
  2. Behavior when switching during pending transactions
  3. Race conditions when multiple network change requests occur simultaneously

Ticket

APKT-2902

Link to Devin run

https://app.devin.ai/sessions/79e00274bb0b46b7968a84a13ed9f36a

Requested by

[email protected]

Testing

  • Ran tests locally and all tests pass

⚠️ No Changeset found

Latest commit: 692425ff538e48f3a4e001b19dde32e728cfc3e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 17 '25 21:05 changeset-bot[bot]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • [ ] Disable automatic comment and CI monitoring

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2025 7:49am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2025 7:49am
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) May 22, 2025 7:49am
appkit-basic-example ⬜️ Ignored (Inspect) May 22, 2025 7:49am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) May 22, 2025 7:49am
appkit-basic-up-example ⬜️ Ignored (Inspect) May 22, 2025 7:49am
appkit-ethers5-bera ⬜️ Ignored (Inspect) May 22, 2025 7:49am
appkit-nansen-demo ⬜️ Ignored (Inspect) May 22, 2025 7:49am
appkit-vue-solana ⬜️ Ignored (Inspect) May 22, 2025 7:49am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) May 22, 2025 7:49am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) May 22, 2025 7:49am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) May 22, 2025 7:49am
vue-wagmi-example ⬜️ Ignored (Inspect) May 22, 2025 7:49am

vercel[bot] avatar May 17 '25 21:05 vercel[bot]

Warnings
:warning: File packages/controllers/tests/controllers/ChainController.test.ts contains a KEY or SECRET

Generated by :no_entry_sign: dangerJS against 044ee663149d43d91f0cd2a23834ee3b11494d54

github-actions[bot] avatar May 17 '25 21:05 github-actions[bot]

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 76.26% 26880 / 35246
🔵 Statements 76.26% 26880 / 35246
🔵 Functions 68% 2270 / 3338
🔵 Branches 83.72% 5354 / 6395
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 100% 100% 100% 100%
Generated in workflow #12015 for commit 692425f by the Vitest Coverage Report Action

github-actions[bot] avatar May 17 '25 21:05 github-actions[bot]

@devin-ai-integration Can you resolve merge conflicts?

enesozturk avatar Jun 02 '25 05:06 enesozturk

The tests are still failing here. Please fix

tomiir avatar Jun 10 '25 11:06 tomiir