web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

[DO NOT MERGE] chore: upgrade valtio to v2

Open enesozturk opened this issue 7 months ago • 5 comments

Description

Upgrades Valtio to v2

Type of change

  • [x] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

  • [ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [ ] My changes generate no new warnings
  • [ ] I have reviewed my own code
  • [ ] I have filled out all required sections
  • [ ] I have tested my changes on the preview link
  • [ ] Approver of this PR confirms that the changes are tested on the preview link

enesozturk avatar May 16 '25 08:05 enesozturk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 10:26am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 10:26am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 10:26am
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
appkit-basic-example ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 10:26am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 2, 2025 10:26am

vercel[bot] avatar May 16 '25 08:05 vercel[bot]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedesbuild@​0.25.5911007188100
Addedpostcss@​8.5.3991008191100
Addedreact@​19.1.01001008397100
Addedtypescript@​5.8.310010089100100
Addedreact-dom@​19.1.01001009297100

View full report

socket-security[bot] avatar May 16 '25 08:05 socket-security[bot]

Warnings
:warning:

🔑 Potential High‑entropy string detected in packages/experimental/package.json (line 25): dist/types/exports/e...

:warning:

🔑 Potential High‑entropy string detected in packages/experimental/package.json (line 25): dist/types/exports/e...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit/package.json (line 39): dist/types/exports/l...

:warning:

🔑 Potential High‑entropy string detected in packages/appkit/package.json (line 39): dist/types/exports/l...

Generated by :no_entry_sign: dangerJS against 30f9b41441dc5c4059fd9bffc6ba12108b9a77b1

github-actions[bot] avatar May 16 '25 08:05 github-actions[bot]

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.85% 30845 / 39621
🔵 Statements 77.85% 30845 / 39621
🔵 Functions 68.77% 2539 / 3692
🔵 Branches 84.4% 6404 / 7587
File CoverageNo changed files found.
Generated in workflow #13104 for commit 30f9b41 by the Vitest Coverage Report Action

github-actions[bot] avatar May 16 '25 08:05 github-actions[bot]

🦋 Changeset detected

Latest commit: 30f9b41441dc5c4059fd9bffc6ba12108b9a77b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-wallet-button Patch
@reown/appkit-utils Patch
@reown/appkit-experimental Patch
@reown/appkit-controllers Patch
@reown/appkit Patch
@reown/appkit-siwe Patch
@reown/appkit-pay Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 16 '25 11:05 changeset-bot[bot]

@enesozturk Are we exposing valtio state somewhere publicly? We shouldn't do it directly, but if we do, do the customers need to use ref then?

lukaisailovic avatar Jul 02 '25 10:07 lukaisailovic

@enesozturk Are we exposing valtio state somewhere publicly? We shouldn't do it directly, but if we do, do the customers need to use ref then?

We are exposing state only via hooks and plain JS functions, but the using ref() only matter when you create state/proxy - so users won't get any issues using the exposed values

enesozturk avatar Jul 02 '25 11:07 enesozturk