Feature Request | Solana signTransaction

[chendatony31]

Link to minimal reproducible example

no demo

Summary

https://docs.reown.com/advanced/multichain/rpc-reference/solana-rpc#returns-3 According to this documentation, signature does not appear to be an optional parameter. As a result, the code at this line https://github.com/reown-com/appkit/blob/main/packages/adapters/solana/src/providers/SolanaWalletConnectProvider.ts#L117 may have an issue where it never reaches the else branch.

We are going to support adding fee-related instructions to transactions in dApps. This requires modifying the origin transaction and returning the updated version. However, this may not work properly with the old RPC response, which only support signatures as return.

Is there any way, such as statistics or version identifiers, to determine which version of appkit the dapp is using? This would help us decide whether to add the fee instructions.

List of related npm package versions

@reown/appkit-adapter-solana 1.7.0

Node.js Version

v18.17.0

Package Manager

[email protected]

[linear[bot]]

APKT-2546 [bug] Solana signTransaction

[Sam-Newman]

Hey Please can you add a recording of the issue you have?
Is it a bug or feature request?

[chendatony31]

check the code here: https://github.com/reown-com/appkit/blob/main/packages/adapters/solana/src/providers/SolanaWalletConnectProvider.ts#L117

As there always have a signature in result , so the code after line125 never reached.