web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

chore: enable metamasks tests

Open lukaisailovic opened this issue 1 year ago • 4 comments

Description

Enabling metamask tests

Type of change

  • [x] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

  • [ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [x] My changes generate no new warnings
  • [x] I have reviewed my own code
  • [x] I have filled out all required sections
  • [ ] I have tested my changes on the preview link
  • [ ] Approver of this PR confirms that the changes are tested on the preview link

lukaisailovic avatar Oct 16 '24 12:10 lukaisailovic

⚠️ No Changeset found

Latest commit: 0613f451299e6980dc45c2385362aa691c34e767

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 16 '24 12:10 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:33am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:33am
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:33am

vercel[bot] avatar Oct 16 '24 12:10 vercel[bot]

Warnings
:warning: Testing spec changed

Generated by :no_entry_sign: dangerJS against 0613f451299e6980dc45c2385362aa691c34e767

github-actions[bot] avatar Oct 16 '24 12:10 github-actions[bot]

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 307.94000000000005% 4457 / 19401
🔵 Statements 307.94000000000005% 4457 / 19401
🔵 Functions 330.94% 348 / 1036
🔵 Branches 376.68999999999994% 638 / 1334
File CoverageNo changed files found.
Generated in workflow #6869 for commit 0613f45 by the Vitest Coverage Report Action

github-actions[bot] avatar Oct 16 '24 12:10 github-actions[bot]

Closing this as this requires more investigation and feasibility. It's such a bit implementation that requires a technical doc and discussion with the team. We already have this project in the roadmap and would get back to this with better approach.

cc @lukaisailovic @tomiir

enesozturk avatar Nov 07 '24 11:11 enesozturk