web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

fix: add referrerPolicy to the iframe

Open jd1378 opened this issue 1 year ago • 2 comments

Description

This fixes the problem of iframe not connecting to https://secure.walletconnect.org/sdk?projectId=xxxx due to missing referrer

(this issue was not present with 5.1.1 somehow)

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [x] My changes generate no new warnings
  • [x] I have reviewed my own code
  • [x] I have filled out all required sections

jd1378 avatar Sep 05 '24 12:09 jd1378

@jd1378 is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 05 '24 12:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 5, 2024 0:25am

vercel[bot] avatar Sep 05 '24 12:09 vercel[bot]

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy#strict-origin-when-cross-origin_2 Closing as this is the default value 🙏

tomiir avatar Dec 23 '24 14:12 tomiir

@jd1378 is this still happening in latest versions?

tomiir avatar Dec 23 '24 14:12 tomiir

default is not same as explicitly setting it I am still patching this in latest versions (without checking after the update), so I don't know if it still happens or not

it has something to do with my CSP, as far as I remember

jd1378 avatar Dec 23 '24 16:12 jd1378