web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

fix(siwe): fix session checks and call onSignIn for 1CA

Open Cali93 opened this issue 1 year ago • 3 comments

Description

  • Fixes a bug where onSignIn wasn't called in the 1CA flow.
  • Sets the session state upon successful signature verification for 1CA.
  • onNewAddress improvements
    • Fixes session checks as the session can be an empty object resulting in always being truthy.
    • Checks against the address in the current session, which is more reliable than previousAddress state variable.
  • Fixes a bug where closing the modal would disconnect the user.

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [X] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [X] My changes generate no new warnings
  • [X] I have reviewed my own code
  • [X] I have filled out all required sections

Cali93 avatar Jul 04 '24 07:07 Cali93

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Aug 8, 2024 10:53am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Aug 8, 2024 10:53am

vercel[bot] avatar Jul 04 '24 07:07 vercel[bot]

What happened with this? @Cali93 @tomiir

ignaciosantise avatar Aug 05 '24 14:08 ignaciosantise

@Cali93 Should we merge this or close it?

lukaisailovic avatar Oct 03 '24 14:10 lukaisailovic