web3modal
web3modal copied to clipboard
fix(siwe): fix session checks and call onSignIn for 1CA
Description
- Fixes a bug where
onSignInwasn't called in the 1CA flow. - Sets the session state upon successful signature verification for 1CA.
onNewAddressimprovements- Fixes session checks as the session can be an empty object resulting in always being truthy.
- Checks against the address in the current session, which is more reliable than
previousAddressstate variable.
- Fixes a bug where closing the modal would disconnect the user.
Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
Checklist
- [X] Code in this PR is covered by automated tests (Unit tests, E2E tests)
- [X] My changes generate no new warnings
- [X] I have reviewed my own code
- [X] I have filled out all required sections
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| web3modal-gallery | ✅ Ready (Inspect) | Visit Preview | Aug 8, 2024 10:53am |
| web3modal-laboratory | ✅ Ready (Inspect) | Visit Preview | Aug 8, 2024 10:53am |
What happened with this? @Cali93 @tomiir
@Cali93 Should we merge this or close it?