web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

feat(auth): AppKit Auth

Open Cali93 opened this issue 1 year ago • 5 comments

Context

Introduces AppKit Auth. Notable changes:

  • chains has been removed from getMessageParams, we're relying on the chains provided to the connector
  • By using enableAuth: true developers don't need to provide a siweConfig. A default config is used instead.

Type of change

  • [ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

  • [ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [ ] My changes generate no new warnings
  • [ ] I have reviewed my own code
  • [ ] I have filled out all required sections
  • [ ] I have tested my changes on the preview link
  • [ ] Approver of this PR confirms that the changes are tested on the preview link

Cali93 avatar Jun 13 '24 07:06 Cali93

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ❌ Failed (Inspect) Nov 20, 2024 9:04am
appkit-laboratory ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:04am
appkit-vue-solana ❌ Failed (Inspect) Nov 20, 2024 9:04am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 9:04am
vue-wagmi-example ❌ Failed (Inspect) Nov 20, 2024 9:04am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:04am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:04am

vercel[bot] avatar Jun 13 '24 07:06 vercel[bot]

Couple of things that came up while testing this so far (see attached video):

  1. /me seems to be doing a duplicate call on Connect with identical payload returns
  2. I got myself into some bad state where /authenticate always gives me 404 but no indication of what's wrong (repro'd both with Rainbow and Zerion)

Repro for 2.:

  1. I connect first time, get all the way through with /authenticate 200
  2. Disconnect -> observe /sign-out
  3. Restart the flow -> get 404 on /authenticate

https://github.com/WalletConnect/web3modal/assets/8663099/c75666ea-6182-480c-b6d7-f99340a130df

bkrem avatar Jul 05 '24 08:07 bkrem

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 0% 0 / 0
🔵 Statements 0% 0 / 0
🔵 Functions 0% 0 / 0
🔵 Branches 0% 0 / 0
File CoverageNo changed files found.
Generated in workflow #6863 for commit 0d4d438 by the Vitest Coverage Report Action

github-actions[bot] avatar Aug 30 '24 08:08 github-actions[bot]

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 🔺+1.093 🔺+0.397

Current Size

Name Size (kb) Gzip (kb)
assets/index-ukzLjl5y.js 1847.102 532.455
assets/index.js 12.709 4.077
assets/index2.js 11.6 3.209
assets/w3m-modal.js 7.634 2.658
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.094 87.219
assets/hooks.module.js 74.429 25.581
index.html 0.329 0.237
Total Size 2394.878 698.656

Base Size

Name Size (kb) Gzip (kb)
assets/index-C8j32iXT.js 1845.848 532.036
assets/index.js 12.714 4.079
assets/index2.js 11.6 3.215
assets/w3m-modal.js 7.634 2.66
assets/noble-curves.js 31.941 12.779
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.525
index.html 0.329 0.237
Total Size 2393.785 698.259

github-actions[bot] avatar Aug 30 '24 08:08 github-actions[bot]

🦋 Changeset detected

Latest commit: 772cacdaed5e500fbb5a173922199032adb93595

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-adapter-wagmi Patch
@reown/appkit-scaffold-ui Patch
@apps/laboratory Patch
@reown/appkit Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-siwe Patch
@reown/appkit-ui Patch
@apps/demo Patch
@apps/gallery Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 01 '24 09:10 changeset-bot[bot]

Superseded by Cloud Auth development

tomiir avatar Dec 16 '24 16:12 tomiir