web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

[Draft] feat: support web3js

Open Muhammad-Altabba opened this issue 1 year ago • 4 comments

This is currently just a draft.

This MR is to support using web3.js with web3modal.

Breaking Changes

N/A

Changes

  • feat: support web3js
  • chore: read EMAIL_DOMAIN from env variable (and default to 'web3modal.msdc.co' if not provided).

Associated Issues

N/A

Muhammad-Altabba avatar May 03 '24 12:05 Muhammad-Altabba

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ❌ Failed (Inspect) May 16, 2024 6:17pm

vercel[bot] avatar May 03 '24 12:05 vercel[bot]

@Muhammad-Altabba is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 03 '24 12:05 vercel[bot]

Hi thanks for the effort, we won't be adding another package but rather simplify support into a single one for ethers and web3js

glitch-txs avatar May 06 '24 01:05 glitch-txs

Hi thanks for the effort, we won't be adding another package but rather simplify support into a single one for ethers and web3js

Thanks @glitch-txs, We hope this PR gives some ideas on how web3.js could be used with web3modal. Let us know please if we need to provide support for the code changes that would simplify the support of ethers and web3.js into the anticipated single package.

And for now, I published a temporary package as a demo at: https://www.npmjs.com/package/web3modal-web3js

Best regards,

Muhammad-Altabba avatar May 08 '24 10:05 Muhammad-Altabba

Thanks @Muhammad-Altabba! We are planning to migrate from ethers support to a more agnostic approach by exposing the wallet provider on its own so devs would be able to work/choose any ethereum library they wish to use

glitch-txs avatar May 17 '24 11:05 glitch-txs

Hey @Muhammad-Altabba, thank you for such a big contribution. We are working on a general structure refactor for web3modal and as @glitch-txs mentioned we won't need to implement web3.js client explicitly and it'll be library agnostic.

So, closing this for now. But will keep in mind if we need to follow this way. We appreciate your effort. Best!

enesozturk avatar May 21 '24 08:05 enesozturk

We are working on a general structure refactor for web3modal and as @glitch-txs mentioned we won't need to implement web3.js client explicitly and it'll be library agnostic.

@enesozturk where we could track those new updates? Will this refactor be integrated in Appkit?

vittominacori avatar Jun 14 '24 14:06 vittominacori

We are working on a general structure refactor for web3modal and as @glitch-txs mentioned we won't need to implement web3.js client explicitly and it'll be library agnostic.

@enesozturk where we could track those new updates? Will this refactor be integrated in Appkit?

@vittominacori we started working on the big refactor and will be opening the PRs in the upcoming weeks. Currently cannot share a link/doc or something, keep following for the updates please

enesozturk avatar Jun 14 '24 14:06 enesozturk