web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

[bug] Magic Analytics disruptive

Open mergd opened this issue 10 months ago • 5 comments

Link to minimal reproducible example

n/a

Summary

The magic integration creates a lot of requests to Datadog, Vercel, and Segment for data analytics.

I have uBlock origin on, and it clutters up the console log with blocking errors as it keeps trying to post to the analytics endpoint. The easiest fix is to disable my adblocker on localhost, but Magic should also do better and cap the number of retries – especially if its something peripheral like analytics

CleanShot 2024-04-13 at 23 45 49@2x

List of related npm package versions

"@web3modal/siwe": "^4.1.6",
"@web3modal/wagmi": "^4.1.6",

mergd avatar Apr 14 '24 06:04 mergd

Agreed this is extremely annoying although in production those errors go away

TipToe888 avatar May 15 '24 00:05 TipToe888

Same here but on top of that, enableAnalytics: false does not seem to disable it.

cen1 avatar May 27 '24 12:05 cen1

Any updates on this? image

RJKerry avatar Jul 24 '24 16:07 RJKerry

Magic here, those calls are very important to us. But if you're blocking them anyways, capping after a number of retries make sense... Let me bring this up with our team.

ayv8er avatar Aug 06 '24 19:08 ayv8er

Hi all, we've disabled analytics on AppKit. Tested on our end, but would love for you to confirm as well @mergd ?

ayv8er avatar Sep 13 '24 21:09 ayv8er

Please update to latest version to solve this issue

rtomas avatar Sep 14 '24 02:09 rtomas