WalletConnect
feat: support custom connectors
Breaking Changes
N/A
Changes
- feat: support custom connectors
- chore: make return types consistent
- chore: missing and typo comments
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| web3modal-demo | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 10, 2024 2:44pm |
| web3modal-gallery | ✅ Ready (Inspect) | Visit Preview | Jul 10, 2024 2:44pm | |
| web3modal-laboratory | ✅ Ready (Inspect) | Visit Preview | Jul 10, 2024 2:44pm | |
| web3modal-react-wagmi-ex | ✅ Ready (Inspect) | Visit Preview | Jul 10, 2024 2:44pm | |
| web3modal-vue-wagmi-ex | ✅ Ready (Inspect) | Visit Preview | Jul 10, 2024 2:44pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@glitch-txs There's a lot of stuff this function sets up which defaultWagmiConfig() drastically simplifies: WalletConnect, email wallet, RPC URLs, EIP-6963. Lot of lines of code for a dev to re-implement if they just want a new connector, and it wouldn't use our RPC out of the box.
To avoid duplicates we can detect if a connector ID already exists in the list. If it already exists, don't add. That should solve your concerns?
That'd be better I guess.
As a point aside, I think we should also abstract the Blockchain API implementation so it could be used without this function being required.
I'd filter out duplicates and leave it as-is. But this should be included in docs @glitch-txs @boidushya to prevent confusion
