WalletConnect
fix: dayjs locale format seconds is not working and is polluting the global dayjs locale
Breaking Changes
N/A
Changes
- fix:
getRelativeDateFromNowwill no longer return%s secwhen seconds are provided.- [email protected] is expecting
"%d sec"instead of"%s sec"(here's why) to make the proper conversion to "10 sec"
- [email protected] is expecting
- fix: do not pollute the global
enlocale- We found out this bug while using this library on our app. It shouldn't be affecting every app or library that uses this
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| web3modal-demo | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 8, 2024 9:34am |
| web3modal-gallery | ✅ Ready (Inspect) | Visit Preview | May 8, 2024 9:34am | |
| web3modal-laboratory | ✅ Ready (Inspect) | Visit Preview | May 8, 2024 9:34am | |
| web3modal-react-wagmi-ex | ✅ Ready (Inspect) | Visit Preview | May 8, 2024 9:34am | |
| web3modal-vue-wagmi-ex | ✅ Ready (Inspect) | Visit Preview | May 8, 2024 9:34am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@nikosrossolatos is attempting to deploy a commit to the WalletConnect Team on Vercel.
A member of the Team first needs to authorize it.
The dayJS fix LGTM! The namespace pollution fix looks ok, but copying @xzilja and @enesozturk to double check it doesn't have unwanted side-effects.
LGTM
@enesozturk How can I run the vercel or the rest of the checks since I am missing authorisation so that we can merge this PR? :D
@nikosrossolatos seems interesting, I'll investigate this and let you know. The issues are not expected so it shouldn't be a problem for people outside of the team, it's something we should fix unless you touch the GH workflow code.
Vercel ones need to be authorized. I authorized labs, if this is good we can just merge it
Vercel ones need to be authorized. I authorized labs, if this is good we can just merge it
Yeap that's what it saying for me too 😅 missing authorisation. I'll leave this to you then to merge if it's okay