Out of gas for DAI payment handled as success

[ligi]

relaying this from internal QA in a project that uses web3modal.

I elected to purchase the ticket with Dai using Metamask. I accepted the Metamask prompts to transfer, however I did not have enough ETH in my wallet to pay for gas. The UI however said the transaction was successful, while it actually failed. That resulted in an error message - that did however allow me to go back to pay again.

Request that was a "success" but actually failed due to "out of gas".

I guess the gas estimation failed - not sure if this is in the domain of MetaMask or Web3Modal - hope @pedrouid can have a look here.