web-examples icon indicating copy to clipboard operation
web-examples copied to clipboard

Remove eth_sign and eth_signTransaction

Open antondalgren opened this issue 1 year ago • 1 comments

It would be reasonable to remove the support for these methods (eth_sign, eth_signTransaction) due to security reasons to not incentivise wallet developers and dApp developers to use these methods out in the wild. We must currently add exceptions to our supported list of methods to be able to test our wallet integration with the dApp.

References:

  • eth_sign https://twitter.com/CT_IOE/status/1534658825843683328
  • eth_signTransaction https://github.com/MetaMask/metamask-extension/issues/2506 https://github.com/MetaMask/metamask-extension/issues/3475

An alternative would be to make it possible to select what methods you want to send in the sessionProposal from the react-app to the wallet.

antondalgren avatar Dec 14 '22 09:12 antondalgren