walletconnect-monorepo icon indicating copy to clipboard operation
walletconnect-monorepo copied to clipboard

[DO NOT MERGE] fix: prevent network modal from opening randomly on reconnect

Open magiziz opened this issue 7 months ago • 2 comments

Description

When attempting to reconnect after disconnecting, the EP opens the appkit account modal view. This happens because the appkit state is not reset after disconnection.

Type of change

  • [ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Tested on Uniswap and locally

Examples/Screenshots (Optional)

https://github.com/user-attachments/assets/afdf678d-6c6e-474c-bce3-56676438b31c

Checklist

  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

magiziz avatar Apr 29 '25 11:04 magiziz

Missing changesets 🙏

tomiir avatar Apr 29 '25 11:04 tomiir

Will try to do this on the appkit level

magiziz avatar Apr 30 '25 08:04 magiziz