walletconnect-monorepo icon indicating copy to clipboard operation
walletconnect-monorepo copied to clipboard

iso-crypto: Add @walletconnect/encoding as dependency

Open kevinji opened this issue 2 years ago • 1 comments

@walletconnect/iso-crypto uses @walletconnect/encoding directly, so it should be listed as a dependency.

I'm not sure why the package-lock.json got reformatted to use two spaces instead of four after running npm install. Happy to update as needed.

Fixes #844. Closes #1049.

kevinji avatar May 30 '22 01:05 kevinji

@pedrouid do you mind taking a look at this?

kevinji avatar Jun 23 '22 17:06 kevinji

Just updated this PR to fix the merge conflict. @bkrem maybe you could review this?

kevinji avatar Aug 23 '22 22:08 kevinji

Should be in other tags too

beautyfree avatar Nov 07 '22 17:11 beautyfree