walletconnect-monorepo icon indicating copy to clipboard operation
walletconnect-monorepo copied to clipboard
verified publisher icon WalletConnect

ChainId is typed as "number", but is returned as "string"

Open TheDutchCoder opened this issue 3 years ago • 2 comments

Describe the bug The type for chainId is number, but it's actually returned as a string.

SDK Version (if relevant)

  • Client: JS
  • Version 1.7.1

To Reproduce Steps to reproduce the behavior:

  1. Switch networks and log the typeof on chainId
  2. Comes back as a string, not a number

Expected behavior Type to be string (or return value to be a number)

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version 101.0.4951.41

TheDutchCoder avatar May 02 '22 15:05 TheDutchCoder

Try using the latest v1.7.8, and let me know what happens

mubarakone avatar May 04 '22 00:05 mubarakone

Still the same type: chainId: number; in index.d.ts

Package version: "version": "1.7.8",

TheDutchCoder avatar May 19 '22 14:05 TheDutchCoder

@TheDutchCoder is this still an issue?

finessevanes avatar Jan 18 '23 00:01 finessevanes

I no longer work with WalletConnect so I can't verify this issue anymore, sorry.

TheDutchCoder avatar Jan 18 '23 00:01 TheDutchCoder

@TheDutchCoder no problem, thanks for the reply.

finessevanes avatar Jan 18 '23 01:01 finessevanes