create-eth-app icon indicating copy to clipboard operation
create-eth-app copied to clipboard

create meaningful package names

Open TomAFrench opened this issue 5 years ago • 1 comments

Is your feature request related to a problem? Please describe.

All of the generated packages are being given the rather generic names @package/contracts or @package/react-app.

In the case where someone is doing smart contract dev they may wish to publish packages of the solidity contracts or their artifacts for use by others. Having a meaningful package name pre-filled would be useful.

Describe the solution you'd like

For now we could pull the name of directory in which create-eth-app is building the project in and injecting it to take the place of @project. e.g. create eth-app my-eth-app will result in packages with names such as @my-eth-app/contracts

Some preprocessing would need to be done to ensure it results in a legal package name.

Additional context

This can wait for the time being as the currently generated packages won't be being published to npm at all but it's a nice bit of polish all the same.

TomAFrench avatar Jul 17 '20 12:07 TomAFrench

Yeah, this is a nice-to-have.

PaulRBerg avatar Jul 17 '20 14:07 PaulRBerg