WalletConnectSwiftV2 icon indicating copy to clipboard operation
WalletConnectSwiftV2 copied to clipboard

Make `asyncForEach` internal

Open mluisbrown opened this issue 1 year ago • 1 comments

Description

Makes the asyncForEach function in the Sequence extension internal instead of public. The function is only used internally in two private functions, so it doesn't need to be public. If it's public it can clash with extensions of the same name in any projects that use this library.

It also isn't really the purpose of this library to be vending general purpose Sequence extensions.

How Has This Been Tested?

No need to test, only used in 2 private functions internal to WC SDK.

Due Dilligence

  • [ ] Breaking change
  • [ ] Requires a documentation update

mluisbrown avatar Mar 18 '24 17:03 mluisbrown

@llbartekll why did you close this? AFAICT this issue still exists and the fix is very simple.

mluisbrown avatar Aug 19 '24 09:08 mluisbrown

but it breaks the project as this method is imported by other modules

llbartekll avatar Aug 19 '24 09:08 llbartekll

Ok, that's fair enough. You could have mentioned that in the comment for why the PR is being closed 👍

mluisbrown avatar Aug 19 '24 13:08 mluisbrown