WalletConnectSwiftV2
WalletConnectSwiftV2 copied to clipboard
WalletConnect
Update WebSocketConnecting to match latest starscream
Is your feature request related to a problem? Please describe.
I didn't want to rely on starscream for my app, but ran into issues integrating my own socket, so I gave in and updated my app to use the same setup as your example app. Now i'm getting crash reports from the starscream version used in the example project, when it tries to set http headers. I looked into it and noticed your example app is using a fairly old version of starscream and the supplied protocol WebSocketConnecting doesn't match the latest interface.
Describe the solution you'd like
Can you either update WebSocketConnecting so that the latest starscream can be plugged in more easily, or can you provide docs/sample for using the latest. E.g. updating the example to starscream v4+
Describe alternatives you've considered I tired building my own websocket, but i'm having a lot of issues keeping the connection open. By default the inbuilt iOS sockets close after 5 minutes of no messages. I'm having a lot of issues trying to balance the reconnections with users trying to make use of it. The ideal solution here is for WC2 to implement a custom hidden keepalive message, thats sent on a regular basis to keep the socket open, rather than relying on reconnection. Websocket implementations vary wildly across platforms, custom keepalives has been the only reliable means of keeping connections open in various past projects/companies
How to vote for this enhancement?) I believe we are on the same page regarding this matter.
https://github.com/orgs/WalletConnect/discussions/3857
E.g. updating the example to starscream v4+
The default interface matches Starscream v3 because we found it most stable.
but we are currently testing internally URLSession solution, https://github.com/WalletConnect/WalletConnectSwiftV2/pull/911 @simonmcl I would appreciate if you could give your feedback.
