WalletConnectSwiftV2 icon indicating copy to clipboard operation
WalletConnectSwiftV2 copied to clipboard

Published 20 hours ago • verified publisher icon WalletConnect

Redirect back from a wallet to DApp doesn't work on iOS 17

Open maltsevoff opened this issue 1 year ago • 11 comments

Describe the bug Wallets (e. g. MetaMask, Rainbow) don't redirect back to the DApp after successful approve of Connection or Auth request. It doesn't work on iOS 17 but worked on iOS 16.

SDK Version

  • Client: Swift
  • Version 1.8.7
  • iOS Version: 17.0.1

To Reproduce Steps to reproduce the behavior:

  1. Repeat steps from this doc.
  2. Send Auth request to a wallet.
  3. Redirect a user to a wallet using wallet's deeplink/universal link with pairUri in it.
  4. Approve request in a wallet... You'r still in a wallet, no redirect.

Expected behavior A wallet redirect back to the DApp after request approval.

Additional context I've also added redirect property with app links in AppMetadata. But still doesn't work.

maltsevoff avatar Sep 26 '23 14:09 maltsevoff

Same

svatrous avatar Sep 28 '23 11:09 svatrous

Same

ruixhuang avatar Sep 29 '23 16:09 ruixhuang

any updates?

maltsevoff avatar Oct 11 '23 10:10 maltsevoff

same

codepgq avatar Oct 13 '23 09:10 codepgq

same

omidaladini avatar Oct 13 '23 09:10 omidaladini

We are working on an alternative solution that will work for iOS 17 too.

llbartekll avatar Oct 18 '23 05:10 llbartekll

@llbartekll thank your for feedback. Maybe any deadlines when to expect for fix?

maltsevoff avatar Oct 18 '23 07:10 maltsevoff

@maltsevoff for now it's hard to say but I will probably require an sdk upgrade in wallets and dapps so it may take a time to widespread around the ecosystem.

llbartekll avatar Oct 18 '23 08:10 llbartekll

@llbartekll How long should we anticipate for the fix to be released? Are we looking at roughly 3 months, 6 months, or even longer? I'm keen to understand the expected timeframe.

riwa0803 avatar Oct 19 '23 01:10 riwa0803

@riwa0803 we are investigating the problem but there are some technical blockers

llbartekll avatar Oct 25 '23 06:10 llbartekll

coinbase wallet handling it pretty well, and it's working great so, i guess walletconnect should be able to pull it off too

https://github.com/WalletConnect/WalletConnectSwiftV2/assets/6490508/0f8ab087-a300-4dc3-b69a-31428e92a7e6

artignatyev avatar Nov 17 '23 21:11 artignatyev