WalletConnectSwift icon indicating copy to clipboard operation
WalletConnectSwift copied to clipboard

Add "eth_sendTransaction" and "eth_signTypedData" support to Server demo app

Open AlleniCode opened this issue 3 years ago • 4 comments

I fund there was no response when I ran the example project by clicking the "eth_sendTransaction" and "eth_signTypedData" button:

https://example.walletconnect.org

QQ20210731-174214

IMG_0204

@sche @DmitryBespalov

AlleniCode avatar Jul 31 '21 09:07 AlleniCode

This is because the example app has only two handlers: https://github.com/WalletConnect/WalletConnectSwift/blob/9297fba1901d93d68418ee1b761b27ae2410ef0c/ExampleApps/ServerApp/MainViewController.swift#L42 This is expected behaviour

sche avatar Aug 02 '21 12:08 sche

This is because the example app has only two handlers:

https://github.com/WalletConnect/WalletConnectSwift/blob/9297fba1901d93d68418ee1b761b27ae2410ef0c/ExampleApps/ServerApp/MainViewController.swift#L42

This is expected behaviour

Could you please complete the "eth_sendTransaction" and "eth_signTypedData" handlers? Thanks!

AlleniCode avatar Aug 03 '21 01:08 AlleniCode

@sche Hello,have you updated this?

AlleniCode avatar Aug 12 '21 11:08 AlleniCode

Sorry @AlleniCode , not yet. This task is not of a high priority for us at the moment, so it might take some time to update demo apps. You can find an example of how "eth_sendTransaction" is handled here https://github.com/gnosis/safe-ios/blob/8e32e1fa1cf8cc4783f0224b2f96c8eff458659b/Multisig/UI/WalletConnect/WCRequestsHandler.swift#L49

sche avatar Aug 16 '21 08:08 sche