WalletConnectRust icon indicating copy to clipboard operation
WalletConnectRust copied to clipboard

fix: use erc6492 lib and remove dedicated ERC-1271 verification logic

Open chris13524 opened this issue 1 year ago • 0 comments

Description

Refactors the ERC-6492 and ERC-1271 logic into the dedicated erc6492 library. Removes all the Foundry logic and unnecessary dependencies.

EOA verification remains as it was already written and it saves on an RPC request. This dedicated case likely only works due to old SDK versions who didn't support ERC-6492 anyway.

Also updates GetProvider to accept a Provider rather than a Url. Updates BlockchainApiProvider to re-use the reqwest client for all invocations.

Remaining work:

  • [x] Remove default cacao feature

How Has This Been Tested?

Existing tests

Due Diligence

  • [ ] Breaking change
  • [ ] Requires a documentation update
  • [ ] Requires a e2e/integration test update

chris13524 avatar Apr 28 '24 00:04 chris13524