strapi-plugin-placeholder icon indicating copy to clipboard operation
strapi-plugin-placeholder copied to clipboard

Published 20 hours ago • verified publisher icon WalkingPizza

Update node engine to use LTS versions 18 (and soon 20)

Open MattieBelt opened this issue 1 year ago • 5 comments

With Active LTS starting for v20 the 24th of October, it would be good to update the engine config in package.json. This way we won't run into an incompatibility error when install the package. Also since last September v16 is EOL.

error The engine "node" is incompatible with this module. Expected version ">=12.x.x <=18.x.x". Got "20.5.1"
error Found incompatible module.

https://nodejs.dev/en/about/releases image

MattieBelt avatar Oct 19 '23 11:10 MattieBelt

Maybe an even better solutions would be to remove the engine config as strapi itselfs handles it. See this comment on an other strapi plugin: https://github.com/ckeditor/strapi-plugin-ckeditor/pull/84#issuecomment-1781305549

MattieBelt avatar Oct 27 '23 11:10 MattieBelt

The main project has conflict with newer versions of strapi on node 20 . please merge if possible

Ki4wn avatar Dec 04 '23 18:12 Ki4wn

It would be great to get it merged 🙏

artemkarpovich avatar Feb 01 '24 16:02 artemkarpovich

Please merge this, I'd like to update to node 20!

douwepausma avatar Feb 05 '24 09:02 douwepausma

@WalkingPizza could you take a look please?

artemkarpovich avatar Feb 05 '24 11:02 artemkarpovich