Kevin Antonio Rateni Iatauro
Kevin Antonio Rateni Iatauro
Let me know if you find a better way of doing this, I'd be more than happy to modify the PR. The only reason why I am more keen on...
Hey @alexandrebodin, will this be merged eventually? No pressure, just wondering!
PS: I also added a quick check to verify that the `onClick` prop is actually defined before calling it in `handleClick`.
I guess you'll have to hire me then 😂 Just to confirm, the changes also apply to the button when focusing it? Do I modify the rest of the tag...
Have any changes been made to the `disabled` state? Do we still make the whole Tag gray-ish?
Added the `actionLabel` prop and the relative `aria-label` attributed and implemented the hover/focus states.
What exactly would you like to modify in the Tag's story?
I suppose you mean [here](https://github.com/WalkingPizza/strapi-design-system/blob/29658467ae28113470c23bc8b935ecfd69a451a5/packages/strapi-design-system/src/Tag/Tag.stories.mdx?plain=1#L34) and [here](https://github.com/WalkingPizza/strapi-design-system/blob/29658467ae28113470c23bc8b935ecfd69a451a5/packages/strapi-design-system/src/Tag/Tag.stories.mdx?plain=1#L37), but I have two questions: 1. Do we need an `actionLabel` even when `onClick` is not defined, since there is technically no action?...
Since the button is being rendered as a `span`, is it semantically correct to still have the `disabled` and `aria-disabled` attributes in there? I am asking because the color of...
You should consider just yeeting the icons from components altogether, they are painfully annoying to pick because of the limited selection and don't really serve a purpose that is not...