raaghu-react icon indicating copy to clipboard operation
raaghu-react copied to clipboard
verified publisher icon Wai-Technologies

Design System > Element > Dialog > Enhancement as per Figma Design Kit

Open trivenikulkarni opened this issue 10 months ago • 6 comments

Design System > Element > Dialog > Enhancement as per Figma Design Kit

trivenikulkarni avatar Feb 12 '25 17:02 trivenikulkarni

Not fixed on stage 1)Cross button functionality is not done Image 2)unable to see okay button in dark button Image 3)Alignment issue for small and large mobile views for "small size"

Image Image

ketakikotwal avatar Mar 26 '25 08:03 ketakikotwal

Hello @ketakikotwal, 1st point is not valid as we are not implementing functionality on element level. ha but in case this is modal or off canvas or something like that so it should be close on click of cross button.

CC : @RadhikaB123 @trivenikulkarni

supriyartambewaiin avatar Apr 11 '25 07:04 supriyartambewaiin

Reopen on staging Unable to see button text Image

Text size should be same as per WF Icon should be same as per WF Image | Expected-

Image

RadhikaB123 avatar Apr 14 '25 09:04 RadhikaB123

Fixed issue in this PR - https://github.com/Wai-Technologies/raaghu-react/pull/1959/files

supriyartambewaiin avatar Apr 16 '25 12:04 supriyartambewaiin

Fixed on staging

Image

Image

RadhikaB123 avatar Apr 17 '25 11:04 RadhikaB123

fixed on prod

Image

RadhikaB123 avatar Apr 18 '25 11:04 RadhikaB123