WahlNetwork
VM: Memory and CPU limits Test - Request for Change
Currently these tests are just seeing if the CPU/Memory limit is set to unlimited. And the remediate is just to allow it to be set to unlimited
This isn't anything major, it is just to recommend allowing users to specify the limit or to specify that they want it to be unlimited.
These are my suggested updates: Memory: https://gist.github.com/Midacts/8f0c03394325f598eb6b46a4def40729 CPU: https://gist.github.com/Midacts/b010caa61489bd31636dfae3a0f63ebc
I had to refresh my memory on what the original tests looked like before commenting. To summarize it appears that you would like to change the test type from a bool to int where the previous tests asked "Do you want this enabled or not?" with the expectation that most people would say no and the test would then "fix" that. Your suggestions offer the capability to say "Not only do I want it enabled, and here are the values I want to use."
IMO, the tests as written fill the need that I have in that in most cases I don't want to specify limits and I want to find and undo the settings for any VMs that are misconfigured per my environment rules.
Since you're suggesting the change I am assuming you want to use the same limits on all VMs (or a large chunk of VMs)? I'm almost wondering if we should split the tests for the community on who wants have this enabled/disabled, and for those that want to take it an extra step and configure what the values are.
I don't see a reason to split the tests out.
The suggested update does what it currently does, but it also allows the user the ability to specify a limit, as well as unlimited (as right now it basically just allows for unlimited true/false).