Wagner Trezub

Results 28 comments of Wagner Trezub

@tiberiuichim Interesting way of thinking, I will remember this in the future. And no, I hadn't seen the list indenting behavior. I'm going to reintroduce that part of the code,...

@plone/volto-accessibility I'll try to run some tests within our theme to see if I can find any conflicts.

All good here for me.

@JeffersonBledsoe @ichim-david Can we merge this one?

> > I think it requires a small note in the upgrade guide though, it can be seen as a breaking change. > > @pnicolli @Wagner3UB I find it strange...

> Maybe we can add some code examples in the upgrade guide to show the exact class name. Otherwise lgtm as well. @nileshgulia1 Sure, add info is never a problem!

@JeffersonBledsoe I think we are done here! ~~Only thing to do is the backport to 18.x.x~~ @pnicolli @stevepiercy We have your blessing?

@pnicolli Ok, completely understood. Thank you.

@pnicolli @sneridagh Done, I have removed the plone/components part. Now we are good to go.

@cekk I did the modifications suggested by @pnicolli, but there are some fail unit tests to re-do. Can you please run those tests and fix it if needed?