Improve performance when roleFormat == none

[ehestigoni]

trafficstars

Hi all, I've noticed that when roleFormat is set to 'none' waffle fetches the user groups through windowsIdentity.getGroups() but the info is not used anywhere.

In a system with a domain controller, the getGroups task can be very expensive.

Should we getGroups only when roleFormat is different from 'none'?

[hazendaz]

@ehestigoni Can you point to where that is in the code for quick reference here?

[ehestigoni]

Sure. https://github.com/Waffle/waffle/blob/cfe5bc7950b2136dcd10f93addb02238f657782b/Source/JNA/waffle-tomcat9/src/main/java/waffle/apache/GenericWindowsPrincipal.java#L61

https://github.com/Waffle/waffle/blob/cfe5bc7950b2136dcd10f93addb02238f657782b/Source/JNA/waffle-tomcat9/src/main/java/waffle/apache/GenericWindowsPrincipal.java#L79

[ehestigoni]

@hazendaz (Just in case you did not get buzz from the post above). Cheers.

[hazendaz]

Got it thanks

Get Outlook for Androidhttps://aka.ms/ghei36

---

From: Eduardo [email protected] Sent: Sunday, September 24, 2017 10:09:16 PM To: Waffle/waffle Cc: Jeremy Landis; Mention Subject: Re: [Waffle/waffle] Improve performance when roleFormat == none (#552)

@hazendazhttps://github.com/hazendaz (Just in case you did not get buzz from the post above). Cheers.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Waffle/waffle/issues/552#issuecomment-331759679, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA7ho51-5XumhgroaFBdosxVqb2hW6Gyks5slwtMgaJpZM4PdTXn.

[hazendaz]

@dblock Does this issues ring any bells for you?