waffle icon indicating copy to clipboard operation
waffle copied to clipboard

Tests for group 'Everyone' not portable when locale isn't English

Open michael-o opened this issue 8 years ago • 3 comments

My Windows locale is de_DE and I see this test failure:

[ERROR] Failures:
[ERROR]   NegotiateAuthenticatorTests.testNegotiate:200
[INFO]
[ERROR] Tests run: 27, Failures: 1, Errors: 0, Skipped: 0

The reason is this snippet:

Assert.assertTrue(windowsPrincipal.getGroups().containsKey("Everyone"));

It assumes that the group name is always English which is not case. Ideally, the test would rely on SID only in such cases on have it transformed from SID to well-known local name.

michael-o avatar Jun 07 '17 15:06 michael-o

Certainly if you can figure out a better way to test the same, I say go for it and submit a PR.

hazendaz avatar Jun 10 '17 22:06 hazendaz

Can you convert from SID to localized string with Waffle? If so, one could take the well-known SID and have to translated by the Windows API for us.

michael-o avatar Jun 11 '17 08:06 michael-o

@michael-o I'll look into this issue as well. Thanks.

hazendaz avatar Jun 13 '17 00:06 hazendaz