dyn365-ce-vsts-tasks icon indicating copy to clipboard operation
dyn365-ce-vsts-tasks copied to clipboard

Solution Checker Critical Threshold Ignored

Open filcole opened this issue 2 years ago • 1 comments

Hi Wael,

I noticed that the critical threshold is ignored by the solution checker quality gate task. I think this is because the CriticalThreshold is not included in the CheckParams object that's passed to the CheckerQualityGate.ps1 script.

See here: https://github.com/WaelHamze/dyn365-ce-vsts-tasks/blob/19a2b913d56e80c8a53b6999b82dbbe2cf372b2d/BuildTools/Xrm.CI.Framework.BuildTools/Tasks/MSCRMCheckerQualityGate/MSCRMCheckerQualityGate.ps1#L62

filcole avatar Jan 12 '23 02:01 filcole

@filcole thanks for flagging this will take a look

WaelHamze avatar Mar 28 '23 20:03 WaelHamze