maciNTosh icon indicating copy to clipboard operation
maciNTosh copied to clipboard

A few cleanups

Open neuschaefer opened this issue 1 year ago • 3 comments

Hi,

while trying to build maciNTosh in GitHub Actions CI, I ended up fixing a few things. Please take what you like :)

neuschaefer avatar Nov 04 '24 18:11 neuschaefer

I'm not sure if I want to have github ci present in this repo.

That said, the other commits look good, can you squash them?

Wack0 avatar Nov 04 '24 18:11 Wack0

I'm not sure if I want to have github ci present in this repo.

That said, the other commits look good, can you squash them?

I always find squashing to be a rather lossy deal because it breaks the connection between specific commit message and content, so I prefer not to. I'll remove the CI commit though, and see what I can squash without significant loss of information.

I'm also a bit unsure about the last two (Work around(?) LD error: PHDR segment not covered by LOAD segment and Ignore incompatible-type errors). They point to real problems with newer toolchains, but the solutions might be problematic.

EDIT: feel free to merge now

neuschaefer avatar Nov 04 '24 19:11 neuschaefer

rebased, and removed questionable commits (-Wno-...) for now

neuschaefer avatar Nov 19 '24 01:11 neuschaefer