GabrielePuliti
GabrielePuliti
@Hierosme I set the pr in draft, just set as "ready for review" when you are ready to propose, as for now we will simply follow the comments and do...
I want to point that @BugliL was working on the new cli and advance testing in this pr: https://github.com/Schroedinger-Hat/ImageGoNord-cli/pull/25 He has done a impressive job on the mocking testing, see...
I've not strong opinion too, we can use the cli in here just for the sake of test of the pip package and use the cli repository to enhance the...
Hi @Hierosme, the rebase it used to be done by the author of the pull request in order to remove the conflicts in the merge. I can do it for...
Sorry for the late of the updates, but I was working on other things :pray: I resolve all the requested and also fix other typo that I found for puppeteer!
I'll move this as a draft until your branch is not merged. Blocked by #131
Hi, I've created a parallel pr #2607 with 100% code coverage. @ggardet can cherry-pick the 2 commits I've added or we can merge mine.
And looking at the result of the action, it seems like is ok now (except for the lint errors) https://github.com/Schrodinger-Hat/Daje/actions/runs/9516686436/job/26233502758?pr=25
@davideimola there is a lint problem with https://github.com/Schrodinger-Hat/Daje/blob/72c6f14761358ecad0559766f6fb7efaadf8c5d1/pkg/cmd/init/init.go#L15 You can find it here: https://github.com/Schrodinger-Hat/Daje/actions/runs/9517315920/job/26235612772?pr=25#step:3:32 Do you know how to solve it?