Ziqiang Wu

C/C++(Extension) error

1

 

Correct Memory Allocation for temp1 in page_cache.h

2

I noticed the code in include/page_cache.h: https://github.com/ZaidQureshi/bam/blob/d20ef4ac5d4513a411422e41caf48562977504dc/include/page_cache.h#L810 Wondering if it should be: ```c++ uint64_t* temp1 = new uint64_t[np]; ``` or ```c++ uint64_t* temp1 = (uint64_t*) malloc(np * sizeof(uint64_t)); ```

Hi, I'm looking at this line of code from (https://github.com/ZaidQureshi/bam/blob/d20ef4ac5d4513a411422e41caf48562977504dc/include/page_cache.h#L775) and I'm trying to understand the meaning of ctrl.ctrl->page_size * uints_per_page in the following snippet: ```c++ const uint32_t uints_per_page =...