Google-Shortcuts-Launcher icon indicating copy to clipboard operation
Google-Shortcuts-Launcher copied to clipboard
verified publisher icon WSTxda

feat(deps): Update Android SDK Version to 34

Open trindadedev13 opened this issue 1 year ago • 5 comments

As you know, this PR is not ready, because TileService#startActivityAndCollapse is deprecated in SDK 34 and above.

trindadedev13 avatar Aug 23 '24 23:08 trindadedev13

In api 34 StartActivityAndCollapse in MusicSearchQuickSettings is deprecated, need create another method to collapse qs painel after lauch intent.

WSTxda avatar Aug 24 '24 13:08 WSTxda

In api 34 StartActivityAndCollapse in MusicSearchQuickSettings is deprecated, need create another method to collapse qs painel after lauch intent.

okay, I'll take a look later then

trindadedev13 avatar Aug 24 '24 17:08 trindadedev13

@WSTxda please re-view PR

trindadedev13 avatar Aug 25 '24 03:08 trindadedev13

Ok, i made the decision to just update the java, then keep the sdk target to 33, due this reason https://github.com/WSTxda/Google-Shortcuts-Launcher/pull/6#discussion_r1730208283

WSTxda avatar Aug 26 '24 16:08 WSTxda

Ok, i made the decision to just update the java, then keep the sdk target to 33, due this reason #6 (comment)

OK, I won't close the PR, but I'll mark it as a draft. When I have time, I'll study it to see something that can replace this call without the depreciation, of course, that is, if you don't find it first.

trindadedev13 avatar Aug 26 '24 18:08 trindadedev13