egon.io
egon.io copied to clipboard
WPS
Save state to prevent lost work on page reload
I have introduced a new concept into the domain called "SaveState", with a service for creating and loading the current state of the application. The purpose for this is to prevent work from being lost when the application is reloaded ( see #110 ).
I have done my best to avoid conflicting this with the existing "Autosave". What I have created wouldn't require enabling or setting the save interval, max saves, etc. Thinking about this more, I imagine the current "Autosave" to then be more like a "Backup save" that would allow the user to revert back to a previous save state. If this PR gets merged then perhaps Autosave would be refactored to have a SaveState property for storing the title, description, and story and a separate property for the domain config rather than the single "ConfigAndDST" that it has now.
I have included tests, and made sure I didn't break the existing tests. The two test failures from SvgService and AppComponent were present before this PR. I also noticed that importing a story can cause errors and break things, but again I believe that is unrelated to this PR.
Thanks for your PR! We're still working on finishing the port to Angular, especially concerning the UI. I've made finishing the refactoring our priority and we'll merge your PR after that - currently, I'd say it is more likely to be merged in v2.1.0 rather than v2.0.0.
Thanks for your PR! We're still working on finishing the port to Angular, especially concerning the UI. I've made finishing the refactoring our priority and we'll merge your PR after that - currently, I'd say it is more likely to be merged in v2.1.0 rather than v2.0.0.
That's amazing, thank you! I'll be sure to keep an eye on things and resolve any conflicts along the way to make sure this can be automatically merged when the time comes.
Hey @hofstef! I just stumbled back on this PR, and am wondering how is the port to Angular coming along? I'd love to help if you're looking for collabs.
Hey @hofstef! I just stumbled back on this PR, and am wondering how is the port to Angular coming along? I'd love to help if you're looking for collabs.
Hi, we made little progress unfortunately. But we are committed to devope more time and developers to Egon next year.
I've rebased the PR to keep it up to date
@mikelhamer We plan to have the angular version up and running by the end of next week. After that we will look at the PR.
@AlexanderZellober Awesome, thanks! Funny timing because I just picked the domain storytelling book back up last week to dive in and reread / finish it.
Hey. Im sorry. I deleted the branch by accident. Nevertheless, Im going to add this functionality now.
