GRIP icon indicating copy to clipboard operation
GRIP copied to clipboard

Use OpenJDK version of JPackage

Open AustinShalit opened this issue 5 years ago • 5 comments
trafficstars

Just testing to see if this fixes the MacOS launch issue.

AustinShalit avatar Sep 08 '20 14:09 AustinShalit

Codecov Report

Merging #969 into master will increase coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #969      +/-   ##
============================================
+ Coverage     52.35%   52.36%   +0.01%     
  Complexity        1        1              
============================================
  Files           333      333              
  Lines          9080     9080              
  Branches        575      575              
============================================
+ Hits           4754     4755       +1     
  Misses         4121     4121              
+ Partials        205      204       -1     

codecov-commenter avatar Sep 08 '20 15:09 codecov-commenter

I think I am trying to revert #965 with this PR.

AustinShalit avatar Sep 08 '20 15:09 AustinShalit

This fixes the MacOS launch issue but not the memory issue.

AustinShalit avatar Sep 08 '20 16:09 AustinShalit

@AustinShalit is this good to merge?

JLLeitschuh avatar Apr 28 '21 15:04 JLLeitschuh

Need to test this again.

AustinShalit avatar Apr 28 '21 15:04 AustinShalit