GRIP icon indicating copy to clipboard operation
GRIP copied to clipboard

Add morphology operation

Open ArchdukeTim opened this issue 7 years ago • 6 comments

This adds the opencv morphologyEx function. More info here

ArchdukeTim avatar Dec 28 '17 00:12 ArchdukeTim

Codecov Report

Merging #874 into master will increase coverage by 0.1%. The diff coverage is 66.66%.

@@             Coverage Diff             @@
##             master     #874     +/-   ##
===========================================
+ Coverage     51.71%   51.81%   +0.1%     
- Complexity     1158     1160      +2     
===========================================
  Files           247      248      +1     
  Lines          7812     7862     +50     
  Branches        533      533             
===========================================
+ Hits           4040     4074     +34     
- Misses         3591     3607     +16     
  Partials        181      181

codecov-io avatar Dec 28 '17 02:12 codecov-io

I'm good with this. I assume you tested this and it worked the way you wanted?

JLLeitschuh avatar Dec 28 '17 16:12 JLLeitschuh

Yeah. Although I'm not sure how you feel about my hard coded enums. I couldn't figure out where to get that value from since the other ones use 'generated' code but I can't find it.

ArchdukeTim avatar Dec 28 '17 17:12 ArchdukeTim

How do I add things to code generation? It's not very useful without it

ArchdukeTim avatar Dec 28 '17 17:12 ArchdukeTim

So i updated the python code to alleviate this I think. Instead of putting the function in process, it puts it in __init__. However the java code seems to allocate every variable in process which is...weird. I'm not entirely sure if this is a good idea or not, but it's more close to the code I would write freehand

ArchdukeTim avatar Dec 29 '17 16:12 ArchdukeTim

@SamCarlberg Do you have any time to finish up this PR? I don't really at this exact moment.

JLLeitschuh avatar Dec 10 '18 20:12 JLLeitschuh