GRIP
GRIP copied to clipboard
Add morphology operation
This adds the opencv morphologyEx
function. More info here
Codecov Report
Merging #874 into master will increase coverage by
0.1%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #874 +/- ##
===========================================
+ Coverage 51.71% 51.81% +0.1%
- Complexity 1158 1160 +2
===========================================
Files 247 248 +1
Lines 7812 7862 +50
Branches 533 533
===========================================
+ Hits 4040 4074 +34
- Misses 3591 3607 +16
Partials 181 181
I'm good with this. I assume you tested this and it worked the way you wanted?
Yeah. Although I'm not sure how you feel about my hard coded enums. I couldn't figure out where to get that value from since the other ones use 'generated' code but I can't find it.
How do I add things to code generation? It's not very useful without it
So i updated the python code to alleviate this I think. Instead of putting the function in process, it puts it in __init__
. However the java code seems to allocate every variable in process which is...weird. I'm not entirely sure if this is a good idea or not, but it's more close to the code I would write freehand
@SamCarlberg Do you have any time to finish up this PR? I don't really at this exact moment.