rsvp icon indicating copy to clipboard operation
rsvp copied to clipboard

74fix

Open LiviaButtons opened this issue 2 years ago • 2 comments

Modified function rsvp_buildAdditionalQuestions to make the questions and answers translateable. Works with WPML string translation - AKA you navigate the website, WPML finds the translateable strings, and you can then translate the questions and answers. Does not work with general WPML translation, it doesn't find the strings automatically.

Not tested with other translation plugins.

LiviaButtons avatar Mar 13 '22 08:03 LiviaButtons

Merging this will lead to PHPCS/WPCS security issues regarding WordPress Standards ( escaping output ). Also, I don't think this is the best way to translate questions, it's a more hacky way to do it, as translating a variable is not quite correct ( __( $a, 'text-domain ); ) as it will interfere with the automatic translation parser ( see https://developer.wordpress.org/reference/functions/__/ ).

@giucu91 could you also take a look at this?

@LiviaButtons thank you for the PR, we understand that the plugin doesn't quite go along with translations right now and we are sorry for that :( We'll try to make it more compatible with available translators in the future.

Warmly, Razvan

razvanaldea89 avatar Jun 06 '23 15:06 razvanaldea89

Also, beware of a leftover $ here: https://github.com/WPChill/rsvp/pull/79/commits/30288d53b981e954bb7660f75c67a6c642c25b81#diff-b03ed6e4fb1539ed9ef802b2b878d17f0976562719ee3b472f5cbf7e72d2cf14R481

razvanaldea89 avatar Jun 06 '23 15:06 razvanaldea89