OAuth1 icon indicating copy to clipboard operation
OAuth1 copied to clipboard

Ensure OAuth1 signature is created as per the spec

Open AlexC opened this issue 9 years ago • 3 comments

AlexC avatar May 21 '15 11:05 AlexC

Update to replace another urldecode with rawurldecode ... fixes issues with signature that contains "+" (they were replaced with spaces)

AlexC avatar Jun 10 '15 15:06 AlexC

I think the 2 rawurlencode() calls on line 627 might be unnecessary. I was seeing a double-encoding of my oauth_callback parameter value and it appears an earlier call to normalize_parameters() takes care of things correctly.

sblaz avatar Jun 25 '15 20:06 sblaz

In my case, normalize_parameters() is really messing up my already partially encoded parameters, so by removing normalize_parameters() instead, I was able to keep the rawurldecode() calls.

See: #91

I have created a PR which merges your changes with AlexC's and removes normalize_parameters() in favor of encoding them in the join_with_equals_sign() function: https://github.com/WP-API/OAuth1/pull/92

coderkevin avatar Nov 06 '15 04:11 coderkevin